Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worker infinite retry #739

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Aug 9, 2024

Resolves #693

  • Skip hint entries when calculating retry count (the number of errors at the end of the oplog) as they can interleave the errors (example: new incoming invocation)
  • Not writing resource create/describe/drop entries in reply mode (this with the lack of the first point caused the infinite retry loop)
  • Fixes an issue where a worker ends up idle when invoked with a non-existing function, as the error was returned earlier than writing the bad invocation to the oplog.

@vigoo
Copy link
Contributor Author

vigoo commented Aug 9, 2024

Made it draft because I realized that the last point makes workers permanently failed if they get invoked with a wrong function name which we don't want. New fix coming to the PR soon.

@vigoo vigoo marked this pull request as ready for review August 9, 2024 15:51
@vigoo vigoo merged commit da58072 into main Aug 9, 2024
14 checks passed
@vigoo vigoo deleted the vigoo/fix-worker-infinite-retry-case branch August 9, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple issues with invoking bad python WASM
2 participants