Fix resource drop functionality in worker-executor - #717 #718
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #717
There were a couple of scenarios here:
let _ =
. This led to diverging behaviour between invokes through worker-service and worker-executorValue::Handle
however, the input json has to be aserde_json::Value::String
(which indirectly represented a resource) resulting in executor failurewasm_rpc::Value
resulted in infinite loop, which is no more the case after this fix. So I definitely think this has to go inThis fix will unblock #660