Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource drop functionality in worker-executor - #717 #718

Merged
merged 15 commits into from
Jul 30, 2024
Merged

Conversation

afsalthaj
Copy link
Contributor

@afsalthaj afsalthaj commented Jul 30, 2024

Fix #717

There were a couple of scenarios here:

  • The group1 integration test uses forwarding.rs which skips validation with metadata, and the result of a drop invoke is unused. To be precise, use of let _ = . This led to diverging behaviour between invokes through worker-service and worker-executor
  • Worker-Executor stored the result in oplog (when a resource is dropped) as an empty array.
  • During dropping the resource, executor expects the input parameter to be a Value::Handle however, the input json has to be a serde_json::Value::String (which indirectly represented a resource) resulting in executor failure
  • All of the above scenario is handled in this PR.
  • Note that such a wrong expectation of wasm_rpc::Value resulted in infinite loop, which is no more the case after this fix. So I definitely think this has to go in

This fix will unblock #660

@afsalthaj afsalthaj changed the title Drop bug Fix resource drop functionality in worker-executor - #717 Jul 30, 2024
@afsalthaj afsalthaj marked this pull request as ready for review July 30, 2024 12:18
@afsalthaj afsalthaj merged commit 82f7aa4 into main Jul 30, 2024
14 checks passed
@afsalthaj afsalthaj deleted the drop_bug branch July 30, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate the behaviour of Drop Function
2 participants