config workaround #631
Merged
config workaround #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senia-psm
requested review from
vigoo,
noise64,
justcoon,
afsalthaj and
nicoburniske
senia-psm
force-pushed
the
config_workaround
branch
2 times, most recently
from
c37ebcf to
a13e7fa
Compare
justcoon
reviewed
Jul 1, 2024
| namespace: String, | ||
| Grpc { | ||
| // Useless. Just to make config lib happy. | ||
| _dummy: Option<u8>, |
There was a problem hiding this comment.
maybe better is to do Grpc(golem_service_base::model::Empty), like here
https://github.com/golemcloud/golem/blob/main/golem-component-service-base/src/config.rs#L22
There was a problem hiding this comment.
In this case I'll have to replace K8s { namespace: String } with K8s(K8sMode). I'm not sure it worth the refactoring.
WDYT?
There was a problem hiding this comment.
not sure, if it change env variables, maybe we can do it later, ..., if not then it should not be big change
There was a problem hiding this comment.
Done. It was not as bad as I expected.
justcoon
approved these changes
Jul 1, 2024
senia-psm
force-pushed
the
config_workaround
branch
from
a13e7fa to
63be163
Compare
vigoo
approved these changes
Jul 1, 2024
senia-psm
force-pushed
the
config_workaround
branch
from
63be163 to
7868bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.