Fixing API Gateway remaining tickets and bug fixes #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afsalthaj
commented
Jun 2, 2024
|
|
||
| #[derive(Clone)] | ||
| pub struct EvaluationContext { | ||
| pub variables: Option<TypeAnnotatedValue>, | ||
| pub analysed_functions: Vec<AnalysedFunction>, | ||
| pub functions: Vec<Function>, |
There was a problem hiding this comment.
@jdegoes This is not fully what we discussed, but consider this as one step towards what we envisioned, while fixing a bug immediately
There was a problem hiding this comment.
Forward progress, I like it!
jdegoes
reviewed
Jun 3, 2024
| pub struct Function { | ||
| pub fqn: FQN, | ||
| pub arguments: Vec<FunctionParameter>, | ||
| pub return_type: Vec<FunctionResult>, |
jdegoes
reviewed
Jun 3, 2024
| } | ||
| } | ||
|
|
||
| pub fn find_function(&self, function: &str) -> Option<Function> { |
There was a problem hiding this comment.
This is O(n) in number of functions, which is fine for now, but should change to O(log n) at some point.
jdegoes
reviewed
Jun 3, 2024
| ) -> Self { | ||
| let mut request_data = internal::request_type_annotated_value(request); | ||
| let worker_data = create_record("worker", worker_detail.clone().to_type_annotated_value()); | ||
| let merged = request_data.merge(&worker_data); | ||
|
|
||
| let top_level_functions = component_metadata.functions(); |
There was a problem hiding this comment.
This is all a tremendous amount of work to do on each invocation. In the future we need to cache this.
justcoon
approved these changes
Jun 6, 2024
|
Making changes based on the new changes for unification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought of finishing as much API Gateway tickets remaining in the sprint as possible over the weekend.
Fixes #449
Fixes #249
Fixes Function Lookup bug which I found when working with golem-timeline.