Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Nicer error messages #58

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Nicer error messages #58

merged 1 commit into from
Feb 4, 2024

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Feb 4, 2024

  • Proper rendering of GolemErrors and IDs
  • Directly using the error string from the http responses as they already are intended to be user facing (for example WorkerError::NotFound(Json(ErrorBody { error: format!("Template not found: {template_id}"), })) etc.)
  • Removed some implementation details (serde, reqwest, ...)

This should be done in the cloud cli too, and potentially moved to common location.
Also it could be extended to have both a user friendly output and one that is easier to consume from tools built on top of this CLI.

@vigoo vigoo merged commit 034cc08 into master Feb 4, 2024
2 checks passed
@vigoo vigoo deleted the nice-error-messages branch February 4, 2024 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants