-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
singletons-{th,base}
: Require building with GHC 9.12
#620
Conversation
@phadej, do you know what is causing the CI issue here?
I don't observe this when building the code locally, only with |
@RyanGlScott You have two options:
|
Bummer. I suppose we should expedite fixing #532, since that would allow us to finally get rid of the custom |
a44961a
to
f27e294
Compare
I have implemented a fix for #534, and I have rebased this PR on top of it. Sadly, the CI still fails because #534 introduces a dependency on |
08ba505
to
6098243
Compare
I had to do some slightly unsavory things to get there, but I managed to get |
6098243
to
3d1e258
Compare
The most notable change is that because GHC 9.12 includes a fix for https://gitlab.haskell.org/ghc/ghc/-/issues/24911, the test suite output now includes explicit namespaces for its fixity declarations. Aside from that, the changes here are mostly bumping upper version bounds. Checks off one box in #619.
This adds a Haskell-CI patch file containing workarounds for the following `cabal` issues when building with `head.hackage` + GHC 9.12: * haskell/cabal#6522: Remove the use of `head.hackage.ghc.haskell.org:override` in the `cabal` configuration file so that `ghc-paths`' custom `Setup.hs` script can find a suitable `Cabal` version. * haskell/cabal#10500: Remove the use of `allow-newer: *:Cabal *:Cabal-syntax` in the generated `cabal.project` file. We should be able to remove this patch file once we no longer depend on the use of `head.hackage`, as well as when Haskell-CI upgrades to use `cabal-install-3.14`.
3d1e258
to
4ed1541
Compare
Sigh. There is one last obstacle: Hackage simply won't let you upload a package that requires |
The most notable change is that because GHC 9.12 includes a fix for https://gitlab.haskell.org/ghc/ghc/-/issues/24911, the test suite output now includes explicit namespaces for its fixity declarations. Aside from that, the changes here are mostly bumping upper version bounds.
Checks off one box in #619.