Add genQuotedDecs option, generate fixity decs for infix names if False #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch:
* Introduces a `genQuotedDecs :: Bool` option that controls whether
the `q [Dec]` arguments in the `promote` and `singletons` functions
should be generated as part of their output.
* Refactor `promote{Only}` and `singletons{Only}` to use
`genQuotedDecs`.
* Changes `D.S.Promote.promoteInfixDecl` so that it _does_ promote
fixity declarations for infix names when `genQuotedDecs` is
`False`. (See the updated
`Note [singletons and fixity declarations]` in `D.S.Single.Fixity`,
wrinkle 1, for a more detailed explanation.) This fixes #326 in a
much more robust way than the previous hacky workaround in commit
40c736f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
genQuotedDecs :: Booloption that controls whether theq [Dec]arguments in thepromoteandsingletonsfunctions should be generated as part of their output.promote{Only}andsingletons{Only}to usegenQuotedDecs.D.S.Promote.promoteInfixDeclso that it does promote fixity declarations for infix names whengenQuotedDecsisFalse. (See the updatedNote [singletons and fixity declarations]inD.S.Single.Fixity, wrinkle 1, for a more detailed explanation.) This fixes singletonsOnly and fixity declarations for infix names don't play nicely #326 in a much more robust way than the previous hacky workaround in commit 40c736f.