-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(template(main.go)): use go:embed #21
base: master
Are you sure you want to change the base?
Conversation
Upgrade to golang-1.16
Embed template files using `go:embed`.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: ff7b227) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/example/+/313369 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/313369. |
The new Go1.16 gives us a
go:embed
directive.This new feature, to my surprise, is not properly represented by the examples in this repository.
I've bumped the version specified by
go.mod
and usedtemplate.ParseFS
instead oftemplate.ParseFiles
(as portrayed by the package's doc).