-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdownify titles #279
base: main
Are you sure you want to change the base?
Markdownify titles #279
Conversation
I noticed that some of my posts have ' in their titles which don't get properly converted into ’ HTML smart quotes, so I made a setting that can be enabled to fix that. It's turned off by default to avoid messing up existing sites since maybe people have really wacky titles that could get mangled by markdownify.
✅ Deploy Preview for gokarna-hugo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Maybe we should just simply do |
Feel free to revert this if you think it'll cause real breakage
@anthowan Sure, that's what we do with other If you want to use a site param, please add it to the Advanced docs :) |
@anthowan please can you provide screenshots of titles with and without Markdown formatting (e.g. emoji) for review? |
@anthowan Thanks! Could you fix the Markdown-less image, please? |
What do you mean by that? I used the Unicode character 🐈 in the title rather than some shortcode like |
LGTM @526avijitgupta please review & merge if you see it fit |
I noticed that some of my posts have ' in their titles which don't get properly converted into ’ HTML smart quotes, so I passed all occurrences of
.Title
throughmarkdownify
to fix that.