Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pass lighthouse accessibility audits #260

Merged
merged 3 commits into from
Oct 28, 2024
Merged

refactor: pass lighthouse accessibility audits #260

merged 3 commits into from
Oct 28, 2024

Conversation

jamesericdavidson
Copy link
Contributor

@jamesericdavidson jamesericdavidson commented Oct 25, 2024 •
edited
Loading

@jamesericdavidson
fix(index): descend headings sequentially
b1da130
@jamesericdavidson
refactor(header): add aria-label
ea455dc 
make icon-only menu items visible to screen readers using .Identifier
@jamesericdavidson jamesericdavidson marked this pull request as ready for review October 25, 2024 20:16
@jamesericdavidson
Copy link
Contributor Author

jamesericdavidson commented Oct 25, 2024 •
edited
Loading

@526avijitgupta Passes locally (desktop and mobile tests)

image

@jamesericdavidson
Copy link
Contributor Author

@526avijitgupta Did the Netlify deploy bot break when migrating the repo to an organisation?

This was referenced Oct 25, 2024
Open
Closed
@526avijitgupta
Copy link
Member

@jamesericdavidson oh I just commented regarding the same thing here :D :#261 (comment)

Let's verify in one of your open PRs if the deploy previews are working again 🤞

526avijitgupta
526avijitgupta requested changes Oct 27, 2024
View reviewed changes
layouts/index.html Show resolved Hide resolved
@netlify Netlify
Copy link

netlify bot commented Oct 27, 2024 •
edited
Loading

✅ Deploy Preview for gokarna-hugo ready!

Name Link
🔨 Latest commit 5d74124
🔍 Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/671eb4d9bf9e9f000879efd7
😎 Deploy Preview https://deploy-preview-260--gokarna-hugo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jamesericdavidson
Copy link
Contributor Author

@526avijitgupta I think review is failing because it's pointed at index.html

Deploy preview is passing:

image

526avijitgupta
526avijitgupta approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@526avijitgupta 526avijitgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jamesericdavidson 🚀

@526avijitgupta 526avijitgupta merged commit 6e638b5 into gokarna-theme:main Oct 28, 2024
4 checks passed
@jamesericdavidson jamesericdavidson deleted the refactor/lighthouse-accessibility branch October 28, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@526avijitgupta 526avijitgupta 526avijitgupta approved these changes

Assignees

@526avijitgupta 526avijitgupta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesericdavidson @526avijitgupta