Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute CourierMQTT Pods as static frameworks #29

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

sanju-naik
Copy link
Collaborator

Distribute CourierMQTT Pods as static frameworks since they depend on MQTTClientGJ Static XCFramework hence these pods also needs to be distributed as static frameworks

Otherwise while publishing podspec it fails with this error - https://github.com/gojek/courier-iOS/actions/runs/6244143979/job/16950738280

This change is based on the suggestion here - CocoaPods/CocoaPods#7234 (comment)

… MQTTClientGJ Static XCFramework hence these pods also needs to be distributed as static frameworks
Copy link
Member

@alfianlosari alfianlosari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alfianlosari alfianlosari merged commit 5993a94 into gojek:main Sep 20, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants