Add tests for Redux sample code #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettdh
changed the title
Tests for the two ducks' reducers and the patreon epic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding commits as I check off the items in #15.Split off #22 and #23 from #15. Moving away from WIP PRs (i.e. those that are "ready for review but will be added to and then need to be re-reviewed") in favor of self-contained PRs that usually don't need to be re-reviewed - or, in the case of "I want some feedback on code that's not ready to be merged yet", a clear label that indicates the purpose of the PR.
Basically I realized that, once someone approves a PR, there's no way to see whether they've also read and approved any commits that land after their approval. (There is a setting on the repo that resets approvals on push, but I don't want to make reviewers come back just for e.g. typo fixes.)
Closes #15.