WIP: embed ladle stories in documentation #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orteth01
commented
Dec 26, 2024
| @@ -3,7 +3,8 @@ | |||
| "version": "0.1.0", | |||
| "private": true, | |||
| "scripts": { | |||
| "build": "rspress build", | |||
| "build": "rspress build && pnpm run build-ladle", | |||
| "build-ladle": "pnpm --filter=@accelint/design-system exec ladle build -o ../../apps/docs/dist/ladle --base ladle", | |||
There was a problem hiding this comment.
for reference: https://ladle.dev/docs/cli/#build-command
|
I know it isn't the ideal solution but I also know that it isn't the endgame. We can continue to refine it as we go; in fact we will need to. I do, however, believe that we need to have a single experience for the user not two different sites. |
kalisjoshua
approved these changes
Dec 27, 2024
orteth01
requested review from
brandonjpierce,
ArrayKnight and
belsrc
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early WIP For feedback
to test:
from the root directory run
pnpm --filter=@accelint/docs buildpnpm --filter=@accelint/docs preview/packages/design-system/component-stories.htmldemo:
Screen.Recording.2024-12-26.at.2.25.35.PM.mov
Warning
The embed does not currently work when running the
pnpm --filter=@accelint/docs devcommand. Rspress wipes out the dist directory when we run the dev command. i'm going to look into workarounds.✅ Pull Request Checklist:
📝 Test Instructions:
❓ Does this PR introduce a breaking change?
💬 Other information