chore[ci]: ignore generated files #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisjoshua
requested review from
brandonjpierce,
ArrayKnight and
belsrc
as code owners
kalisjoshua
force-pushed
the
fix/missing-config-updates
branch
from
a9e0304 to
fafc69a
Compare
orteth01
approved these changes
Dec 26, 2024
.ls-lint.yml
Outdated
| @@ -30,3 +30,5 @@ ignore: | |||
| - '**/dist' | |||
| - '**/documentation' | |||
| - '**/node_modules' | |||
| - './apps/doc_build' | |||
There was a problem hiding this comment.
nit: for folders we control, stick to kebab-case instead of snake_case
There was a problem hiding this comment.
Agreed. This is the default for rspress.
kalisjoshua
force-pushed
the
fix/missing-config-updates
branch
from
fafc69a to
269fec0
Compare
kalisjoshua
force-pushed
the
fix/missing-config-updates
branch
from
269fec0 to
eacf464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
✅ Pull Request Checklist:
📝 Test Instructions:
❓ Does this PR introduce a breaking change?
💬 Other information