Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): use vitest .each convention for tests #108

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix(tests): use vitest .each convention for tests #108

merged 1 commit into from
Dec 27, 2024
+87 −188

Conversation

kalisjoshua
Copy link
Contributor

@kalisjoshua kalisjoshua commented Nov 20, 2024 •
edited
Loading

Closes #11

✅ Pull Request Checklist:

  • Included link to corresponding GitHub Issue.
  • The commit message follows conventional commit extended guidelines.
  • Added/updated unit tests and storybook for this change (for bug fixes / features).
  • Added/updated documentation (for bug fixes / features)
  • Filled out test instructions.

📝 Test Instructions:

❓ Does this PR introduce a breaking change?

  • Yes
  • No

💬 Other information

@kalisjoshua kalisjoshua linked an issue Nov 20, 2024 that may be closed by this pull request
Vitest conventions #11
Closed
@kalisjoshua kalisjoshua force-pushed the feat/11-vitest-conventions branch from a4aa174 to 3a78c83 Compare November 20, 2024 19:30
@kalisjoshua kalisjoshua linked an issue Nov 20, 2024 that may be closed by this pull request
Change yesno predicate away from regex #77
Closed
@belsrc
Copy link
Contributor

belsrc commented Nov 20, 2024

As it looks like you doing like 5 things in this one PR. Please try to keep a PR to a single issue.

@kalisjoshua
Copy link
Contributor Author

As it looks like you doing like 5 things in this one PR. Please try to keep a PR to a single issue.

I did let things get away from me on this one. I can break things up they are pretty small. Should I?

@kalisjoshua kalisjoshua force-pushed the feat/11-vitest-conventions branch from 3a78c83 to de9e9a5 Compare November 21, 2024 14:57
@belsrc
Copy link
Contributor

belsrc commented Nov 21, 2024

I did let things get away from me on this one. I can break things up they are pretty small. Should I?

If you don't mind I would appreciate it. Just makes it easier to discuss each thing individually without context switching and makes it a lot easier to track work.

@kalisjoshua kalisjoshua force-pushed the feat/11-vitest-conventions branch 2 times, most recently from 3f30b07 to 8982b4d Compare November 21, 2024 16:39
@kalisjoshua
Copy link
Contributor Author

I believe this is only making changes to tests at this point. I moved the common fixtures to the constants/ module because that felt more natural and consistent; to have the consumers both referencing it from there rather than one referencing it in another module.

@kalisjoshua kalisjoshua changed the title fix[tests]: use vitest .each convention for tests fix(tests): use vitest .each convention for tests Nov 22, 2024
@kalisjoshua kalisjoshua force-pushed the feat/11-vitest-conventions branch from 8982b4d to 83beba8 Compare November 22, 2024 18:02
This was unlinked from issues Nov 22, 2024
Vitest conventions #11
Closed
Change yesno predicate away from regex #77
Closed
@kalisjoshua kalisjoshua linked an issue Nov 22, 2024 that may be closed by this pull request
Vitest conventions #11
Closed
@kalisjoshua kalisjoshua force-pushed the feat/11-vitest-conventions branch 2 times, most recently from b85875b to 07859f4 Compare December 3, 2024 16:05
@kalisjoshua kalisjoshua force-pushed the feat/11-vitest-conventions branch 3 times, most recently from 12ea115 to a484c63 Compare December 4, 2024 18:38
@kalisjoshua kalisjoshua force-pushed the feat/11-vitest-conventions branch 2 times, most recently from 8cd5e43 to 0dd8ab8 Compare December 18, 2024 20:28
@kalisjoshua kalisjoshua force-pushed the feat/11-vitest-conventions branch from 0dd8ab8 to 428ecc0 Compare December 18, 2024 20:38
@kalisjoshua kalisjoshua force-pushed the feat/11-vitest-conventions branch from 428ecc0 to dcfe56a Compare December 18, 2024 20:39
@kalisjoshua kalisjoshua added refactor A code change that neither fixes a bug nor adds a feature test Adding missing tests or correcting existing tests labels Dec 23, 2024
@brandonjpierce brandonjpierce merged commit e7d9a8a into main Dec 27, 2024
3 checks passed
@brandonjpierce brandonjpierce deleted the feat/11-vitest-conventions branch December 27, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArrayKnight ArrayKnight ArrayKnight left review comments

@belsrc belsrc belsrc left review comments

@brandonjpierce brandonjpierce brandonjpierce approved these changes

@switzerb switzerb Awaiting requested review from switzerb

Assignees
No one assigned
Labels
refactor A code change that neither fixes a bug nor adds a feature test Adding missing tests or correcting existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vitest conventions
4 participants
@kalisjoshua @belsrc @ArrayKnight @brandonjpierce