fix[tests]: use vitest .each convention for tests

additionally clean up folder names for fixtures. issue #11
gohypergiant · Nov 20, 2024 · a4aa174 · a4aa174
1 parent 86604c4
commit a4aa174
Show file tree

Hide file tree

Showing 31 changed files with 6,879 additions and 6,961 deletions.
diff --git a/.secrets.baseline b/.secrets.baseline
diff --git a/packages/__fixtures__/boolean.ts b/packages/__fixtures__/boolean.ts
@@ -0,0 +1,45 @@
+/*
+ * Copyright 2024 Hypergiant Galactic Systems Inc. All rights reserved.
+ * This file is licensed to you under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License. You may obtain a copy
+ * of the License at https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under
+ * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS
+ * OF ANY KIND, either express or implied. See the License for the specific language
+ * governing permissions and limitations under the License.
+ */
+
+// biome-ignore lint/suspicious/noExplicitAny: <explanation>
+type Callable = (...a: any[]) => any;
+type Fixture = [string, boolean, Callable, Values][];
+// biome-ignore lint/suspicious/noExplicitAny: <explanation>
+type Values = any[];
+
+export const truthy: Values = [
+  1,
+  '1',
+  'on',
+  'true',
+  'yes',
+  true,
+  'ON',
+  'YES',
+  'TRUE',
+];
+export const falsey: Values = [
+  0,
+  '0',
+  'off',
+  'false',
+  'no',
+  false,
+  [],
+  {},
+  'OFF',
+  'NO',
+  'FALSE',
+];
+
+export const createFixture = (bool: boolean, ...rest: [Values, Callable][]) =>
+  rest.map(([values, fn]) => [fn.name, bool, fn, values]) as Fixture;
diff --git a/packages/constants/package.json b/packages/constants/package.json
@@ -4,9 +4,7 @@
   "private": false,
   "license": "Apache-2.0",
   "type": "module",
-  "files": [
-    "dist/**"
-  ],
+  "files": ["dist/**"],
   "types": "./dist/index.d.ts",
   "exports": {
     ".": {

diff --git a/packages/constants/tsup.config.ts b/packages/constants/tsup.config.ts
@@ -10,7 +10,7 @@ export default defineConfig({
   entry: [
     'src/**/*.{ts,tsx}',
     '!src/**/*.{d,stories,test,test-d,bench}.{ts,tsx}',
-    '!**/__fixture__',
+    '!**/__fixtures__',
   ],
   bundle: true,
   clean: true,

diff --git a/packages/converters/package.json b/packages/converters/package.json
@@ -4,9 +4,7 @@
   "private": false,
   "license": "Apache-2.0",
   "type": "module",
-  "files": [
-    "dist/**"
-  ],
+  "files": ["dist/**"],
   "types": "./dist/index.d.ts",
   "exports": {
     ".": {

diff --git a/packages/converters/src/boolean-to-number/index.test.ts b/packages/converters/src/boolean-to-number/index.test.ts
@@ -13,15 +13,12 @@
 import { describe, expect, it } from 'vitest';
 import { booleanToNumber } from './';
 
-const testPairs: [boolean, number][] = [
-  [true, 1],
-  [false, 0],
-];
-
 describe('bool to number', () => {
-  for (const [input, result] of testPairs) {
-    it(`should convert ${input} to ${result}`, () => {
-      expect(booleanToNumber(input)).toEqual(result);
-    });
-  }
+  it.each`
+    input    | result
+    ${true}  | ${1}
+    ${false} | ${0}
+  `('should convert $input to $result', ({ input, result }) => {
+    expect(booleanToNumber(input)).toEqual(result);
+  });
 });
diff --git a/packages/converters/src/to-boolean/index.test.ts b/packages/converters/src/to-boolean/index.test.ts
@@ -10,34 +10,21 @@
  * governing permissions and limitations under the License.
  */
 
-import { expect, it, describe } from 'vitest';
-import { toBoolean } from './';
+import { describe, expect, it } from 'vitest';
 
-const truthy = [1, '1', 'on', 'true', 'yes', true, 'ON', 'YES', 'TRUE'];
-const falsey = [
-  0,
-  '0',
-  'off',
-  'false',
-  'no',
-  false,
-  [],
-  {},
-  'OFF',
-  'NO',
-  'FALSE',
-];
+import { createFixture, falsey, truthy } from '../../../__fixtures__/boolean';
 
-describe('toBoolean', () => {
-  for (const item of truthy) {
-    it(`should return true for ${item}`, () => {
-      expect(toBoolean(item)).toBeTruthy();
-    });
-  }
+import { toBoolean } from './';
 
-  for (const item of falsey) {
-    it(`should return false for ${item}`, () => {
-      expect(toBoolean(item)).not.toBeTruthy();
+describe('toBoolean', () => {
+  describe.each([
+    // positive cases
+    ...createFixture(true, [truthy, toBoolean]),
+    // negative cases
+    ...createFixture(false, [falsey, toBoolean]),
+  ])('%s', (_name, expected, fn, values) => {
+    it.each(values)(`should return "${expected}" for %j`, (value) => {
+      expect(fn(value)).toBe(expected);
     });
-  }
+  });
 });
diff --git a/packages/converters/tsup.config.ts b/packages/converters/tsup.config.ts
@@ -10,7 +10,7 @@ export default defineConfig({
   entry: [
     'src/**/*.{ts,tsx}',
     '!src/**/*.{d,stories,test,test-d,bench}.{ts,tsx}',
-    '!**/__fixture__',
+    '!**/__fixtures__',
   ],
   bundle: true,
   clean: true,

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -4,9 +4,7 @@
   "private": false,
   "license": "Apache-2.0",
   "type": "module",
-  "files": [
-    "dist/**"
-  ],
+  "files": ["dist/**"],
   "types": "./dist/index.d.ts",
   "exports": {
     ".": {

diff --git a/packages/core/tsup.config.ts b/packages/core/tsup.config.ts
@@ -10,7 +10,7 @@ export default defineConfig({
   entry: [
     'src/**/*.{ts,tsx}',
     '!src/**/*.{d,stories,test,test-d,bench}.{ts,tsx}',
-    '!**/__fixture__',
+    '!**/__fixtures__',
   ],
   bundle: true,
   clean: true,

diff --git a/packages/design-system/package.json b/packages/design-system/package.json
@@ -10,9 +10,7 @@
   "private": false,
   "sideEffects": false,
   "type": "module",
-  "files": [
-    "dist/**"
-  ],
+  "files": ["dist/**"],
   "types": "./dist/index.d.ts",
   "exports": {
     ".": {

diff --git a/packages/formatters/package.json b/packages/formatters/package.json
@@ -4,9 +4,7 @@
   "private": false,
   "license": "Apache-2.0",
   "type": "module",
-  "files": [
-    "dist/**"
-  ],
+  "files": ["dist/**"],
   "types": "./dist/index.d.ts",
   "exports": {
     ".": {

diff --git a/packages/formatters/tsup.config.ts b/packages/formatters/tsup.config.ts
@@ -10,7 +10,7 @@ export default defineConfig({
   entry: [
     'src/**/*.{ts,tsx}',
     '!src/**/*.{d,stories,test,test-d,bench}.{ts,tsx}',
-    '!**/__fixture__',
+    '!**/__fixtures__',
   ],
   bundle: true,
   clean: true,

diff --git a/packages/geo/package.json b/packages/geo/package.json
@@ -4,9 +4,7 @@
   "private": false,
   "license": "Apache-2.0",
   "type": "module",
-  "files": [
-    "dist/**"
-  ],
+  "files": ["dist/**"],
   "types": "./dist/index.d.ts",
   "exports": {
     ".": {

diff --git a/packages/geo/tsup.config.ts b/packages/geo/tsup.config.ts
@@ -10,7 +10,7 @@ export default defineConfig({
   entry: [
     'src/**/*.{ts,tsx}',
     '!src/**/*.{d,stories,test,test-d,bench}.{ts,tsx}',
-    '!**/__fixture__',
+    '!**/__fixtures__',
   ],
   bundle: true,
   clean: true,

diff --git a/packages/math/package.json b/packages/math/package.json
@@ -4,9 +4,7 @@
   "private": false,
   "license": "Apache-2.0",
   "type": "module",
-  "files": [
-    "dist/**"
-  ],
+  "files": ["dist/**"],
   "types": "./dist/index.d.ts",
   "exports": {
     ".": {

diff --git a/packages/math/tsup.config.ts b/packages/math/tsup.config.ts
@@ -10,7 +10,7 @@ export default defineConfig({
   entry: [
     'src/**/*.{ts,tsx}',
     '!src/**/*.{d,stories,test,test-d,bench}.{ts,tsx}',
-    '!**/__fixture__',
+    '!**/__fixtures__',
   ],
   bundle: true,
   clean: true,

diff --git a/packages/predicates/package.json b/packages/predicates/package.json
@@ -4,9 +4,7 @@
   "private": false,
   "license": "Apache-2.0",
   "type": "module",
-  "files": [
-    "dist/**"
-  ],
+  "files": ["dist/**"],
   "types": "./dist/index.d.ts",
   "exports": {
     ".": {

diff --git a/packages/predicates/src/is-noyes/index.test.ts b/packages/predicates/src/is-noyes/index.test.ts
@@ -10,24 +10,33 @@
  * governing permissions and limitations under the License.
  */
 
-import { describe, it, expect } from 'vitest';
-import { isTrue, isYes, isFalse, isNo } from './';
+import { describe, expect, it } from 'vitest';
 
-const truthy = [1, '1', 'on', 'true', 'yes', true, 'ON', 'YES', 'TRUE'];
-const falsey = [0, '0', 'off', 'false', 'no', false, 'OFF', 'NO', 'FALSE'];
+import { createFixture, falsey, truthy } from '../../../__fixtures__/boolean';
 
-describe('boolean validators', () => {
-  for (const item of truthy) {
-    it(`should return true for ${item}`, () => {
-      expect(isTrue(item)).toBeTruthy();
-      expect(isYes(item)).toBeTruthy();
-    });
-  }
+import { isFalse, isNo, isTrue, isYes } from './';
 
-  for (const item of falsey) {
-    it(`should return false for ${item}`, () => {
-      expect(isFalse(item)).toBeTruthy();
-      expect(isNo(item)).toBeTruthy();
+describe('boolean validators', () => {
+  describe.each([
+    // positive cases
+    ...createFixture(
+      true,
+      [falsey, isFalse],
+      [falsey, isNo],
+      [truthy, isTrue],
+      [truthy, isYes],
+    ),
+    // negative cases
+    ...createFixture(
+      false,
+      [truthy, isFalse],
+      [truthy, isNo],
+      [falsey, isTrue],
+      [falsey, isYes],
+    ),
+  ])('%s', (_name, expected, fn, values) => {
+    it.each(values)(`should return "${expected}" for %j`, (value) => {
+      expect(fn(value)).toBe(expected);
     });
-  }
+  });
 });