Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files #20791

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Remove unused files #20791

merged 2 commits into from
Oct 24, 2024

Conversation

stonezdj
Copy link
Contributor

Use this PR to remove unused files in Harbor project

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner July 30, 2024 06:38
@stonezdj stonezdj added the release-note/ignore-for-release Do not include PR or Issue for release notes label Jul 30, 2024
   fix golint warnings

Signed-off-by: stonezdj <[email protected]>
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.08%. Comparing base (c8c11b4) to head (dbc9259).
Report is 307 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20791       +/-   ##
===========================================
+ Coverage   45.36%   66.08%   +20.71%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114649   +101316     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    75767    +69718     
- Misses       6983    34740    +27757     
- Partials      301     4142     +3841     
Flag Coverage Δ
unittests 66.08% <ø> (+20.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1288 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vad1mo Vad1mo enabled auto-merge (squash) August 20, 2024 16:41
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Oct 20, 2024
@Vad1mo Vad1mo changed the title [WIP] Remove unused files Remove unused files Oct 24, 2024
@Vad1mo Vad1mo merged commit 21de424 into goharbor:main Oct 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants