-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip Loginview create when credentials already exist #275
Open
qcserestipy
wants to merge
10
commits into
goharbor:main
Choose a base branch
from
qcserestipy:267_login_with_config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p login view creation if some credentials exist Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
ed config behavior to login docs Signed-off-by: Patrick Eschenbach <[email protected]>
… in the keyring with a specified user and service Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
To resolve the failing tests I will introduce a mock Keyring since the container has no keyring. |
…ed test for encryption functions; Updated config and login tests with mock key ring provider Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
qcserestipy
changed the title
!WIP: Skip Loginview create when credentials already exist
Skip Loginview create when credentials already exist
Dec 4, 2024
Vad1mo
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
Check for Existing Credentials and Bypass Login View Creation
ToDo: Add base64 encoding for password in config file?