Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Loginview create when credentials already exist #275

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

qcserestipy
Copy link
Contributor

Fixes #267

Check for Existing Credentials and Bypass Login View Creation

  1. Implemented a verification step to detect existing Harbor credentials in the current configuration.
  2. If valid credentials are found, the creation of a new login view is skipped.
  3. Enhances login efficiency by reusing stored credentials and reducing unnecessary prompts.

ToDo: Add base64 encoding for password in config file?

…p login view creation if some credentials exist

Signed-off-by: Patrick Eschenbach <[email protected]>
ed config behavior to login docs

Signed-off-by: Patrick Eschenbach <[email protected]>
… in the keyring with a specified user and service

Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
@qcserestipy
Copy link
Contributor Author

To resolve the failing tests I will introduce a mock Keyring since the container has no keyring.

…ed test for encryption functions; Updated config and login tests with mock key ring provider

Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
@qcserestipy qcserestipy changed the title !WIP: Skip Loginview create when credentials already exist Skip Loginview create when credentials already exist Dec 4, 2024
@Vad1mo Vad1mo requested a review from bupd December 10, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storing Plaintext in Config Files is Insecure
3 participants