Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Validation Domain for login command #271

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Standing-Man
Copy link
Contributor

fixed #269.

Add the Validation function

@bupd bupd self-requested a review November 30, 2024 00:10
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens for those use cases:

  • subdomain with prot -> subdomain.domain.com:port
  • ip -> 127.0.0.1 and 127.0.0.1:8080
  • top level domain -> registry.com

@Standing-Man
Copy link
Contributor Author

Standing-Man commented Dec 4, 2024

Hi @Vad1mo, the validation method allow these cases:

  • demo.gohabor.io and demo.goharbor.io:8080
  • 127.0.0.1 and 127.0.0.1:80
  • top level domain like registry.com

The port cannot be less than 0 or greater than 65535 and it validates each label in the domain name for correctness.

@Standing-Man Standing-Man requested a review from Vad1mo December 4, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Validation for Server in login
2 participants