Better errormessage #266
Open
Better errormessage #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bupd
requested changes
Nov 26, 2024
pkg/utils/error.go
Outdated
Comment on lines
8
to
18
| func ErrorStatusCode(err error) int64 { | ||
| re := regexp.MustCompile(`\[(\d{3})\]`) | ||
| matches := re.FindStringSubmatch(err.Error()) | ||
| var statusCode int64 | ||
|
|
||
| if len(matches) > 1 { | ||
| stringCode := matches[1] | ||
| statusCode, _ = strconv.ParseInt(stringCode, 10, 64) | ||
| } | ||
| return statusCode | ||
| } |
There was a problem hiding this comment.
implement a better way to get the status code. since regex can fail in different scenarios.
There was a problem hiding this comment.
I think we only have the option to extract the status code from the error message.
Althaf66
force-pushed
the
errormessage
branch
from
ea04245 to
cb5437e
Compare
Signed-off-by: ALTHAF <[email protected]>
Signed-off-by: ALTHAF <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed error messages for registry