feat: Add systemcve cli cmd #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ALTHAF <[email protected]>
Signed-off-by: ALTHAF <[email protected]>
|
ready for review |
harbor security-hub
harbor scanners
harbor scan-schedule |
|
For this PR I would suggest calling it harbor cve-allowlist list/add
|
Signed-off-by: ALTHAF <[email protected]>
Signed-off-by: ALTHAF <[email protected]>
Signed-off-by: ALTHAF <[email protected]>
Signed-off-by: ALTHAF <[email protected]>
Vad1mo
reviewed
Nov 19, 2024
pkg/api/systemcve_handler.go
Outdated
| } | ||
| var unixTimestamp int64 | ||
| if opts.IsExpire { | ||
| expiresAt, err := time.Parse("01/02/2006", opts.ExpireDate) |
There was a problem hiding this comment.
use ISO 8601 as default: with
YYYY-MM-DD
Signed-off-by: ALTHAF <[email protected]>
Vad1mo
requested changes
Dec 10, 2024
| func CVEAllowlist() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "cve-allowlist", | ||
| Short: "Manage system CVE allowlist", |
There was a problem hiding this comment.
Short: "Manage system CVE allowlist",
Long: `Manage system level allowlist of CVE`,
The description is almost the same, maybe we can have a longer explanation.
| } | ||
|
|
||
| flags := cmd.Flags() | ||
| flags.BoolVarP(&opts.IsExpire, "isexpire", "i", false, "Systemcve allowlist expire or not") |
There was a problem hiding this comment.
This text makes no sense: "Systemcve allowlist expire or not"
| flags := cmd.Flags() | ||
| flags.BoolVarP(&opts.IsExpire, "isexpire", "i", false, "Systemcve allowlist expire or not") | ||
| flags.StringVarP(&opts.CveId, "cveid", "n", "", "CVE ids seperate with commas") | ||
| flags.StringVarP(&opts.ExpireDate, "expiredate", "d", "", "If it expire,give Expiry date in the format MM/DD/YYYY") |
There was a problem hiding this comment.
This text makes little sense without deep context "If it expire,give Expiry date in the format MM/DD/YYYY"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created systemcve command for updating and listing systemcve allowlist.
harbor systemcve updateharbor systemcve list