Allow SPAs with registered http server to serve rest endpoints #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Mart
changed the title
James-Mart
changed the title
James-Mart
force-pushed
the
check-registered-http-server-first
branch
from
cd6fcd7
to
abc800a
Compare
swatanabe
reviewed
Oct 4, 2024
swatanabe
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcoming with the http server impl was discovered specifically when dealing with SPAs:
For example:
Chainmail is registered as an SPA, so any request that doesn't specify an extension (which would imply a request for a static asset e.g.
style.css) it assumes is a client route and returns the root document. But that means that API requests like/messages/sender=aliceare just returning the root document.This PR reverses the order in which the servers are checked, checking the registered server first. Only check sites iff the registered server returns
None.