-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring psibase macros #870
Open
cool-ant
wants to merge
24
commits into
main
Choose a base branch
from
mm/restructing-psibase-macros
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cool-ant
force-pushed
the
mm/restructing-psibase-macros
branch
from
October 3, 2024 16:04
e5f4f90
to
260bf16
Compare
cool-ant
force-pushed
the
mm/restructing-psibase-macros
branch
from
October 21, 2024 18:49
f60e1b9
to
3c50f06
Compare
…e; repo is building
…f attrs and mod working; code compiles
…yet split into modules
…acro-transformed state should look like
cool-ant
force-pushed
the
mm/restructing-psibase-macros
branch
from
October 22, 2024 15:26
ce554f8
to
1629e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the psibase_macros into a 3-project workspace for easier dev/testing.
In addition to the 3-project structure, it also splits service_macro.rs into separate files for better readability/maintainability.
There are a couple of TODOs but only in the test files and are notes for tests I can add; nothing functionally missing from this PR.