Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Storage Driver: Etcd #878

Merged
merged 15 commits into from
Jul 4, 2023
Merged

New Storage Driver: Etcd #878

merged 15 commits into from
Jul 4, 2023

Conversation

erkanzsy
Copy link
Contributor

@erkanzsy erkanzsy commented Jul 3, 2023

Hey guys, this pr aims to add new Storage implementation of Etcd.
Used this package.

Thanks for the reviews.

etcd/README.md Outdated Show resolved Hide resolved
etcd/README.md Outdated Show resolved Hide resolved
@ReneWerner87
Copy link
Member

Thx for the effort, looks good beside the readme mistakes

@erkanzsy
Copy link
Contributor Author

erkanzsy commented Jul 3, 2023

Thx for the effort, looks good beside the readme mistakes

Thanks for your review.

.github/workflows/test-etcd.yml Outdated Show resolved Hide resolved
etcd/go.mod Outdated Show resolved Hide resolved
.github/workflows/test-etcd.yml Show resolved Hide resolved
@erkanzsy erkanzsy requested a review from gaby July 3, 2023 20:53
etcd/config.go Show resolved Hide resolved
Copy link
Member

@gaby gaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erkanzsy
Copy link
Contributor Author

erkanzsy commented Jul 3, 2023

LGTM

Thanks for your time.

@ReneWerner87 ReneWerner87 merged commit f0e4fda into gofiber:main Jul 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants