Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Storage Driver: Cassandra #856

Closed
wants to merge 23 commits into from
Closed

Conversation

aliziyacevik
Copy link

Hey guys, this is the continuum of #852 which I accidentally closed and messed up so I opened this.

Thanks for the reviews.

@aliziyacevik
Copy link
Author

Hi @gaby, since #852 is closed I opened this.

@gaby
Copy link
Member

gaby commented Jun 18, 2023

@aliziyacevik Can you update the gosec.yml inside github to exclude cassandra for the root test, and include cassandra at the botton of the file

@gaby
Copy link
Member

gaby commented Jun 18, 2023

@aliziyacevik This may be related, not sure yet

apache/cassandra-gocql-driver#997

@aliziyacevik
Copy link
Author

no problem @gaby, I will work on that to find a solution. thanks for your help.

@aliziyacevik
Copy link
Author

hi @gaby, right now I'm assuming the GitHub ci/cd doesn't wait for Cassandra to be available on port 9042, that's why it can't pass the test. what do you think ?

@gaby
Copy link
Member

gaby commented Jun 18, 2023

hi @gaby, right now I'm assuming the GitHub ci/cd doesn't wait for Cassandra to be available on port 9042, that's why it can't pass the test. what do you think ?

Let me do some research and i will reply back here

@gaby
Copy link
Member

gaby commented Jun 19, 2023

@aliziyacevik I dont think there's a way to run it in gh actions. Setting address to 0.0.0.0 causes container to fail. Cassandra doesnt allow using that

@aliziyacevik
Copy link
Author

@gaby okay, let me also look for a solution

@mstrYoda
Copy link
Member

mstrYoda commented Jun 28, 2023

Hi @aliziyacevik can you just remove the service definition for cassandra and add a new step that calls docker commands directly like I did for couchbase in here and then you can add sleep command after starting cassandra container 👍

@aliziyacevik
Copy link
Author

sure @mstrYoda, the first moment I get on my laptop.

@aliziyacevik
Copy link
Author

I will try @mstrYoda suggests now.

@gaby
Copy link
Member

gaby commented Jul 1, 2023

@aliziyacevik Are you able to connect to a local cassandra instance in your dev env?

@aliziyacevik
Copy link
Author

aliziyacevik commented Jul 1, 2023

Yes @gaby. I opened both in Docker and in my local. They're both working.

@gaby
Copy link
Member

gaby commented Jul 1, 2023

Yes @gaby. I opened both in Docker and in my local. They're both working.

I'm not sure how cassandra work, but can you run a container and only using this Storage driver connect and set/get data? Or did you need to setup CQL files, etc before trying to use the storage driver?

@mstrYoda
Copy link
Member

mstrYoda commented Jul 1, 2023

@aliziyacevik if you would like to, let's get together and make a quick pair on Go Türkiye/Fiber discord channel?

@aliziyacevik
Copy link
Author

Sure @mstrYoda.

@aliziyacevik
Copy link
Author

aliziyacevik commented Jul 2, 2023

I didnt create any etc or CQL file because its not necessary (atleast I thoght) ı will check it out again. @gaby

@ReneWerner87
Copy link
Member

@aliziyacevik can you refresh your branch with the master

@aliziyacevik
Copy link
Author

@mstrYoda when can we make a pair ?

@mstrYoda
Copy link
Member

@mstrYoda when can we make a pair ?

Just ping me on discord 👍

@aliziyacevik
Copy link
Author

aliziyacevik commented Jul 21, 2023

Sorry for the latency guys. I really cant find time to investigate this. Hopefully really soon, I will look at this with @mstrYoda . Just wanted to let you @gaby @ReneWerner87 know. Thanks.

@gaby gaby mentioned this pull request Jul 30, 2023
@gaby
Copy link
Member

gaby commented Jul 30, 2023

@aliziyacevik Can you fix the merge conflicts with the gosec.yml ?

@aliziyacevik
Copy link
Author

aliziyacevik commented Oct 2, 2023

@gaby sure.

@mstrYoda abi naptın bakıyor muyuz buna beraber yayında yoksa fixleyeyim mi ben şimdi ? başka şeyler de yaparız yayında. tabi hala davetliysem :)

@mstrYoda
Copy link
Member

mstrYoda commented Oct 2, 2023

@gaby sure.

@mstrYoda abi naptın bakıyor muyuz buna beraber yayında yoksa fixleyeyim mi ben şimdi ? başka şeyler de yaparız yayında. tabi hala davetliysem :)

I am writing to you on discord again, lets meet 👍

@ReneWerner87
Copy link
Member

@mstrYoda any progress ?

@ReneWerner87
Copy link
Member

@aliziyacevik @mstrYoda friendly ping, thx for the effort

can you update this PR and also check the last hints

@ReneWerner87
Copy link
Member

@aliziyacevik @mstrYoda friendly ping

@aliziyacevik
Copy link
Author

@aliziyacevik @mstrYoda friendly ping

hey @ReneWerner87, Thanks for the reminder and sorry for the such a long delay :(. I will resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants