-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Storage Driver: Cassandra #856
Conversation
@aliziyacevik Can you update the gosec.yml inside github to exclude cassandra for the root test, and include cassandra at the botton of the file |
@aliziyacevik This may be related, not sure yet |
no problem @gaby, I will work on that to find a solution. thanks for your help. |
hi @gaby, right now I'm assuming the GitHub ci/cd doesn't wait for Cassandra to be available on port 9042, that's why it can't pass the test. what do you think ? |
Let me do some research and i will reply back here |
@aliziyacevik I dont think there's a way to run it in gh actions. Setting address to 0.0.0.0 causes container to fail. Cassandra doesnt allow using that |
@gaby okay, let me also look for a solution |
Hi @aliziyacevik can you just remove the service definition for cassandra and add a new step that calls docker commands directly like I did for couchbase in here and then you can add sleep command after starting cassandra container 👍 |
sure @mstrYoda, the first moment I get on my laptop. |
I will try @mstrYoda suggests now. |
@aliziyacevik Are you able to connect to a local |
Yes @gaby. I opened both in Docker and in my local. They're both working. |
I'm not sure how cassandra work, but can you run a container and only using this Storage driver connect and set/get data? Or did you need to setup CQL files, etc before trying to use the storage driver? |
@aliziyacevik if you would like to, let's get together and make a quick pair on Go Türkiye/Fiber discord channel? |
Sure @mstrYoda. |
I didnt create any etc or CQL file because its not necessary (atleast I thoght) ı will check it out again. @gaby |
@aliziyacevik can you refresh your branch with the master |
@mstrYoda when can we make a pair ? |
Just ping me on discord 👍 |
Sorry for the latency guys. I really cant find time to investigate this. Hopefully really soon, I will look at this with @mstrYoda . Just wanted to let you @gaby @ReneWerner87 know. Thanks. |
@aliziyacevik Can you fix the merge conflicts with the gosec.yml ? |
@mstrYoda any progress ? |
@aliziyacevik @mstrYoda friendly ping, thx for the effort can you update this PR and also check the last hints |
@aliziyacevik @mstrYoda friendly ping |
hey @ReneWerner87, Thanks for the reminder and sorry for the such a long delay :(. I will resolve the conflicts. |
Hey guys, this is the continuum of #852 which I accidentally closed and messed up so I opened this.
Thanks for the reviews.