Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new storage implementation: Couchbase #841

Merged
merged 22 commits into from
Jul 3, 2023
Merged

Conversation

mstrYoda
Copy link
Member

This pr aims to add new storage implementation of Couchbase database.

Thank you for your reviews 🙏

couchbase/couchbase.go Outdated Show resolved Hide resolved
Copy link
Member

@efectn efectn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add dependabot, release drafter, test actions
Also edit security workflow

@efectn efectn requested review from gaby and ReneWerner87 May 28, 2023 20:53
go.mod Outdated Show resolved Hide resolved
couchbase/go.mod Outdated Show resolved Hide resolved
@ReneWerner87
Copy link
Member

@mstrYoda can you also update the other workflows(tests ...)

@ReneWerner87
Copy link
Member

pls check gosec
image

@ReneWerner87
Copy link
Member

@mstrYoda can you also update the other workflows(tests ...)

adjustement in the test workflow is still missing

@ReneWerner87
Copy link
Member

changes.patch
@mstrYoda pls add this patch

@mstrYoda
Copy link
Member Author

mstrYoda commented Jun 5, 2023

@mstrYoda can you also update the other workflows(tests ...)

adjustement in the test workflow is still missing

changes.patch @mstrYoda pls add this patch

Hi @ReneWerner87 , I am preparing a full container test pipeline for this development, I will add it ASAP 👍

@ReneWerner87
Copy link
Member

ok thx

@gaby
Copy link
Member

gaby commented Jun 18, 2023

@mstrYoda Any updates on this?

@mstrYoda mstrYoda requested a review from gaby June 24, 2023 09:50
@mstrYoda
Copy link
Member Author

ok thx

@mstrYoda Any updates on this?

Hi fellows 👋

I completed the integration test workflow and manually checked it on my local docker env. Can you review it?

@gaby
Copy link
Member

gaby commented Jun 24, 2023

ok thx

@mstrYoda Any updates on this?

Hi fellows 👋

I completed the integration test workflow and manually checked it on my local docker env. Can you review it?

There's a small merge conflict, before CI runs

@gaby
Copy link
Member

gaby commented Jun 24, 2023

@mstrYoda Something got messed up during the fix of conflicts, all the CI files have old stuff. Did you pull the latest master?

@mstrYoda
Copy link
Member Author

mstrYoda commented Jun 24, 2023

@mstrYoda Something got messed up during the fix of conflicts, all the CI files have old stuff. Did you pull the latest master?

Fixed, I just included conflicted file from the IDE ui mistakenly in previous commit 👍

.github/release-drafter-pebble.yml Outdated Show resolved Hide resolved
.github/workflows/test-bbolt.yml Outdated Show resolved Hide resolved
couchbase/go.mod Outdated Show resolved Hide resolved
@gaby gaby requested review from efectn and ReneWerner87 June 28, 2023 13:45
@ReneWerner87 ReneWerner87 merged commit 6fbb923 into gofiber:main Jul 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants