-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve and Optimize ShutdownWithContext Func #3162
base: main
Are you sure you want to change the base?
feat: Improve and Optimize ShutdownWithContext Func #3162
Commits on Oct 10, 2024
-
feat: Optimize ShutdownWithContext method in app.go
- Reorder mutex lock acquisition to the start of the function - Early return if server is not running - Use defer for executing shutdown hooks - Simplify nil check for hooks - Remove TODO comment This commit improves the readability, robustness, and execution order of the shutdown process. It ensures consistent state throughout the shutdown and guarantees hook execution even in error cases.
yingjie.huang committedOct 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 137da86 - Browse repository at this point
Copy the full SHA 137da86View commit details -
feat: Enhance ShutdownWithContext test for improved reliability
- Add shutdown hook verification - Implement better synchronization with channels - Improve error handling and assertions - Adjust timeouts for more consistent results - Add server state check after shutdown attempt - Include comments explaining expected behavior This commit improves the comprehensiveness and reliability of the ShutdownWithContext test, ensuring proper verification of shutdown hooks, timeout behavior, and server state during long-running requests.
yingjie.huang committedOct 10, 2024 Configuration menu - View commit details
-
Copy full SHA for b41d084 - Browse repository at this point
Copy the full SHA b41d084View commit details
Commits on Oct 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e1ad8e9 - Browse repository at this point
Copy the full SHA e1ad8e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a683166 - Browse repository at this point
Copy the full SHA a683166View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4a5831 - Browse repository at this point
Copy the full SHA a4a5831View commit details -
Merge branch 'main' of github.com:JIeJaitt/fiber into jiejaitt-featur…
…e/improve-shutdown-with-context
Configuration menu - View commit details
-
Copy full SHA for 424ecbb - Browse repository at this point
Copy the full SHA 424ecbbView commit details -
Merge branch 'jiejaitt-feature/improve-shutdown-with-context' of gith…
…ub.com:JIeJaitt/fiber into jiejaitt-feature/improve-shutdown-with-context
Configuration menu - View commit details
-
Copy full SHA for 98fbdff - Browse repository at this point
Copy the full SHA 98fbdffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 796922f - Browse repository at this point
Copy the full SHA 796922fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e465b5b - Browse repository at this point
Copy the full SHA e465b5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee866ec - Browse repository at this point
Copy the full SHA ee866ecView commit details
Commits on Oct 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e0a56be - Browse repository at this point
Copy the full SHA e0a56beView commit details -
Merge branches 'jiejaitt-feature/improve-shutdown-with-context' and '…
…main' of github.com:JIeJaitt/fiber into jiejaitt-feature/improve-shutdown-with-context
Configuration menu - View commit details
-
Copy full SHA for d01a09e - Browse repository at this point
Copy the full SHA d01a09eView commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 750a7fa - Browse repository at this point
Copy the full SHA 750a7faView commit details -
Merge branch 'main' of github.com:JIeJaitt/fiber into jiejaitt-featur…
…e/improve-shutdown-with-context
Configuration menu - View commit details
-
Copy full SHA for 2ea0bb3 - Browse repository at this point
Copy the full SHA 2ea0bb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9509fe - Browse repository at this point
Copy the full SHA b9509feView commit details -
feat: Optimize ShutdownWithContext method in app.go
- Reorder mutex lock acquisition to the start of the function - Early return if server is not running - Use defer for executing shutdown hooks - Simplify nil check for hooks - Remove TODO comment This commit improves the readability, robustness, and execution order of the shutdown process. It ensures consistent state throughout the shutdown and guarantees hook execution even in error cases.
Configuration menu - View commit details
-
Copy full SHA for c2792e7 - Browse repository at this point
Copy the full SHA c2792e7View commit details -
feat: Enhance ShutdownWithContext test for improved reliability
- Add shutdown hook verification - Implement better synchronization with channels - Improve error handling and assertions - Adjust timeouts for more consistent results - Add server state check after shutdown attempt - Include comments explaining expected behavior This commit improves the comprehensiveness and reliability of the ShutdownWithContext test, ensuring proper verification of shutdown hooks, timeout behavior, and server state during long-running requests.
Configuration menu - View commit details
-
Copy full SHA for 18111e5 - Browse repository at this point
Copy the full SHA 18111e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83ea43d - Browse repository at this point
Copy the full SHA 83ea43dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66dcb42 - Browse repository at this point
Copy the full SHA 66dcb42View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3902c5 - Browse repository at this point
Copy the full SHA f3902c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for da193ac - Browse repository at this point
Copy the full SHA da193acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a92125 - Browse repository at this point
Copy the full SHA 0a92125View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0bc70c - Browse repository at this point
Copy the full SHA b0bc70cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44cbc62 - Browse repository at this point
Copy the full SHA 44cbc62View commit details -
Merge branch 'jiejaitt-feature/improve-shutdown-with-context' of gith…
…ub.com:JIeJaitt/fiber into jiejaitt-feature/improve-shutdown-with-context
Configuration menu - View commit details
-
Copy full SHA for 0e99032 - Browse repository at this point
Copy the full SHA 0e99032View commit details
Commits on Oct 29, 2024
-
Merge branch 'main' of github.com:gofiber/fiber into jiejaitt-feature…
…/improve-shutdown-with-context
Configuration menu - View commit details
-
Copy full SHA for a32bddd - Browse repository at this point
Copy the full SHA a32bdddView commit details