-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie parser #2656
Cookie parser #2656
Conversation
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
the issue for this pull request is |
@ReneWerner87 Hello, I would like to know what needs to be done before a PR is approved. |
Currently everything we need is there |
@ReneWerner87 hello Rene, I noticed some checks failed. Is there anything I need to do? |
Yes, pls check the lint errors |
I'll fix all the issues tonight
…On Wed, 11 Oct 2023, 8:09 am RW, ***@***.***> wrote:
[image: image]
<https://user-images.githubusercontent.com/7063188/274173311-5a82d2a4-97af-4f15-bb44-ccd2dd3a58f1.png>
—
Reply to this email directly, view it on GitHub
<#2656 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A25NWE4ID4XXWCSUFU6JBMTX6ZAZDAVCNFSM6AAAAAA5TMYTE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWHE4DOOJQGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sorry for disturbing you, but I'm trying to confirm the last error I just need to add a test for the returned value? @ReneWerner87 |
yes should be act -W ./.github/workflows/linter.yml |
|
bb026a6 fixed |
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Description
Implemented a cookie parser, following the same convention used by BodyParser and QuerryParser context methods.
The parser is a context method which takes a struct pointer as argument and assigns all passed cookies to the relevant fields. It returns an error if any.
The feature was requested as an issue, and provides an easier way to handle multiple cookies, and improves developer experience and development time.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/