Bump golangci-lint to v1.61.0 (#3135)

* Bump golangci-lint to v1.61.0 * Fix golangci warnings
gofiber · Sep 15, 2024 · 0ef8d71 · 0ef8d71 · github-actions · Sep 15, 2024
1 parent 37f1a65
commit 0ef8d71
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml
@@ -37,4 +37,4 @@ jobs:
         uses: golangci/golangci-lint-action@v6
         with:
           # NOTE: Keep this in sync with the version from .golangci.yml
-          version: v1.60.3
+          version: v1.61.0
diff --git a/Makefile b/Makefile
@@ -35,7 +35,7 @@ markdown:
 ## lint: 🚨 Run lint checks
 .PHONY: lint
 lint:
-	go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.3 run ./...
+	go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.61.0 run ./...
 
 ## test: 🚦 Execute all tests
 .PHONY: test

diff --git a/middleware/cache/cache.go b/middleware/cache/cache.go
@@ -63,7 +63,7 @@ func New(config ...Config) fiber.Handler {
 	var (
 		// Cache settings
 		mux       = &sync.RWMutex{}
-		timestamp = uint64(time.Now().Unix())
+		timestamp = uint64(time.Now().Unix()) //nolint:gosec //Not a concern
 	)
 	// Create manager to simplify storage operations ( see manager.go )
 	manager := newManager(cfg.Storage)
@@ -75,7 +75,7 @@ func New(config ...Config) fiber.Handler {
 	// Update timestamp in the configured interval
 	go func() {
 		for {
-			atomic.StoreUint64(&timestamp, uint64(time.Now().Unix()))
+			atomic.StoreUint64(&timestamp, uint64(time.Now().Unix())) //nolint:gosec //Not a concern
 			time.Sleep(timestampUpdatePeriod)
 		}
 	}()

diff --git a/middleware/etag/etag.go b/middleware/etag/etag.go
@@ -65,7 +65,7 @@ func New(config ...Config) fiber.Handler {
 			return c.SendStatus(fiber.StatusRequestEntityTooLarge)
 		}
 
-		bb.B = appendUint(bb.Bytes(), uint32(bodyLength)) //nolint:gosec // Body length is validated above
+		bb.B = appendUint(bb.Bytes(), uint32(bodyLength))
 		bb.WriteByte('-')
 		bb.B = appendUint(bb.Bytes(), crc32.Checksum(body, crc32q))
 		bb.WriteByte('"')
Benchmark suite	Current: `0ef8d71`	Previous: `6e74114`	Ratio
`Benchmark_Ctx_Send`	`7.456` ns/op 0 B/op 0 allocs/op	`4.342` ns/op 0 B/op 0 allocs/op	`1.72`
`Benchmark_Ctx_Send - ns/op`	`7.456` ns/op	`4.342` ns/op	`1.72`
`Benchmark_Utils_GetOffer/1_parameter`	`196.8` ns/op 0 B/op 0 allocs/op	`131.1` ns/op 0 B/op 0 allocs/op	`1.50`
`Benchmark_Utils_GetOffer/1_parameter - ns/op`	`196.8` ns/op	`131.1` ns/op	`1.50`
`Benchmark_Middleware_BasicAuth - B/op`	`80` B/op	`48` B/op	`1.67`
`Benchmark_Middleware_BasicAuth - allocs/op`	`5` allocs/op	`3` allocs/op	`1.67`
`Benchmark_Middleware_BasicAuth_Upper - B/op`	`80` B/op	`48` B/op	`1.67`
`Benchmark_Middleware_BasicAuth_Upper - allocs/op`	`5` allocs/op	`3` allocs/op	`1.67`
`Benchmark_CORS_NewHandler - B/op`	`16` B/op	`0` B/op	`+∞`
`Benchmark_CORS_NewHandler - allocs/op`	`1` allocs/op	`0` allocs/op	`+∞`
`Benchmark_CORS_NewHandlerSingleOrigin - B/op`	`16` B/op	`0` B/op	`+∞`
`Benchmark_CORS_NewHandlerSingleOrigin - allocs/op`	`1` allocs/op	`0` allocs/op	`+∞`
`Benchmark_CORS_NewHandlerPreflight - B/op`	`104` B/op	`0` B/op	`+∞`
`Benchmark_CORS_NewHandlerPreflight - allocs/op`	`5` allocs/op	`0` allocs/op	`+∞`
`Benchmark_CORS_NewHandlerPreflightSingleOrigin - B/op`	`104` B/op	`0` B/op	`+∞`
`Benchmark_CORS_NewHandlerPreflightSingleOrigin - allocs/op`	`5` allocs/op	`0` allocs/op	`+∞`
`Benchmark_CORS_NewHandlerPreflightWildcard`	`1042` ns/op 104 B/op 5 allocs/op	`689.8` ns/op 0 B/op 0 allocs/op	`1.51`
`Benchmark_CORS_NewHandlerPreflightWildcard - ns/op`	`1042` ns/op	`689.8` ns/op	`1.51`
`Benchmark_CORS_NewHandlerPreflightWildcard - B/op`	`104` B/op	`0` B/op	`+∞`
`Benchmark_CORS_NewHandlerPreflightWildcard - allocs/op`	`5` allocs/op	`0` allocs/op	`+∞`
`Benchmark_Middleware_CSRF_GenerateToken - B/op`	`513` B/op	`334` B/op	`1.54`
`Benchmark_Middleware_CSRF_GenerateToken - allocs/op`	`10` allocs/op	`6` allocs/op	`1.67`