✨ enhancement: use msgp for flash message encoding/decoding (#3099)

* enhancement: use msgp for flash message encoding/decoding

* add msgp tests

* improve test coverage

* improve test coverage

* fix linter

* update makefile

* extend go generation process

---------

Co-authored-by: Juan Calderon-Perez <[email protected]>
Co-authored-by: René <[email protected]>

Makefile

@@ -57,11 +57,9 @@ tidy:
 betteralign:
 	go run github.com/dkorunic/betteralign/cmd/betteralign@latest -test_files -generated_files -apply ./...
 
-## tidy: ⚡️ Generate msgp
-.PHONY: msgp
-msgp:
-	go run github.com/tinylib/msgp@latest -file="middleware/cache/manager.go" -o="middleware/cache/manager_msgp.go" -tests=true -unexported
-	go run github.com/tinylib/msgp@latest -file="middleware/session/data.go" -o="middleware/session/data_msgp.go" -tests=true -unexported
-	go run github.com/tinylib/msgp@latest -file="middleware/csrf/storage_manager.go" -o="middleware/csrf/storage_manager_msgp.go" -tests=true -unexported
-	go run github.com/tinylib/msgp@latest -file="middleware/limiter/manager.go" -o="middleware/limiter/manager_msgp.go" -tests=true -unexported
-	go run github.com/tinylib/msgp@latest -file="middleware/idempotency/response.go" -o="middleware/idempotency/response_msgp.go" -tests=true -unexported
+## tidy: ⚡️ Generate msgp && interface implementations
+.PHONY: generate
+generate:
+	go install github.com/tinylib/msgp@latest
+	go install github.com/vburenin/ifacemaker@975a95966976eeb2d4365a7fb236e274c54da64c
+	go generate ./...

ctx.go

@@ -63,7 +63,7 @@ type DefaultCtx struct {
 	pathOriginal        string               // Original HTTP path
 	pathBuffer          []byte               // HTTP path buffer
 	detectionPathBuffer []byte               // HTTP detectionPath buffer
-	redirectionMessages []string             // Messages of the previous redirect
+	flashMessages       redirectionMsgs      // Flash messages
 	indexRoute          int                  // Index of the current route
 	indexHandler        int                  // Index of the current handler
 	methodINT           int                  // HTTP method INT equivalent
@@ -1896,7 +1896,7 @@ func (c *DefaultCtx) release() {
 	c.route = nil
 	c.fasthttp = nil
 	c.bind = nil
-	c.redirectionMessages = c.redirectionMessages[:0]
+	c.flashMessages = c.flashMessages[:0]
 	c.viewBindMap = sync.Map{}
 	if c.redirect != nil {
 		ReleaseRedirect(c.redirect)

middleware/cache/manager.go

@@ -10,7 +10,7 @@ import (
 
 // msgp -file="manager.go" -o="manager_msgp.go" -tests=true -unexported
 //
-//go:generate msgp
+//go:generate msgp -o=manager_msgp.go -tests=true -unexported
 type item struct {
 	headers   map[string][]byte
 	body      []byte

middleware/csrf/storage_manager.go

@@ -11,7 +11,7 @@ import (
 
 // msgp -file="storage_manager.go" -o="storage_manager_msgp.go" -tests=true -unexported
 //
-//go:generate msgp
+//go:generate msgp -o=storage_manager_msgp.go -tests=true -unexported
 type item struct{}
 
 //msgp:ignore manager

middleware/idempotency/response.go

@@ -3,7 +3,7 @@ package idempotency
 // response is a struct that represents the response of a request.
 // generation tool `go install github.com/tinylib/msgp@latest`
 //
-//go:generate msgp -o=response_msgp.go -io=false -tests=true -unexported
+//go:generate msgp -o=response_msgp.go -tests=true -unexported
 type response struct {
 	Headers map[string][]string `msg:"hs"`
 

middleware/limiter/manager.go

@@ -10,7 +10,7 @@ import (
 
 // msgp -file="manager.go" -o="manager_msgp.go" -tests=false -unexported
 //
-//go:generate msgp
+//go:generate msgp -o=manager_msgp.go -tests=false -unexported
 type item struct {
 	currHits int
 	prevHits int

middleware/session/data.go

@@ -6,7 +6,7 @@ import (
 
 // msgp -file="data.go" -o="data_msgp.go" -tests=true -unexported
 //
-//go:generate msgp
+//go:generate msgp -o=data_msgp.go -tests=true -unexported
 type data struct {
 	Data         map[string]any
 	sync.RWMutex `msg:"-"`