Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support sending multiple transactions #275

Closed
wants to merge 5 commits into from
Closed

feat: Support sending multiple transactions #275

wants to merge 5 commits into from

Conversation

oriole-pub
Copy link
Collaborator

@oriole-pub oriole-pub commented Feb 22, 2023

Dependence

Changed

sendTransaction with TransactionManager
Involves deposit / L1 transfer/ get test token

Related

@vercel
Copy link

vercel bot commented Feb 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
godwoken-bridge-mainnet ❌ Failed (Inspect) Feb 24, 2023 at 10:34AM (UTC)
godwoken-bridge-testnet ❌ Failed (Inspect) Feb 24, 2023 at 10:34AM (UTC)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@ba9ea9d). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #275   +/-   ##
==========================================
  Coverage           ?   65.28%           
==========================================
  Files              ?       39           
  Lines              ?     6164           
  Branches           ?      235           
==========================================
  Hits               ?     4024           
  Misses             ?     2137           
  Partials           ?        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9ea9d...9f879ca. Read the comment docs.

@oriole-pub
Copy link
Collaborator Author

This PR is no longer applicable because Lumos has completely rewritten the Transaction Manager.

@oriole-pub oriole-pub closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent double-spending when constructing L1 transactions Suggest to optimize double-spending error prompt
4 participants