Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contractAddress in contracts/test/Eip1898 #309

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix contractAddress in contracts/test/Eip1898 #309

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0cd726
"For `Eip1898.js`, always use `contractAddress`."
sunchengzhu Oct 24, 2023
8e5fbbc
`Eip1898.js` always use `contractAddress`
sunchengzhu Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/test/Eip1898.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ describe("Eip1898 eth_getCode test", function () {
let contractAddress;

if (isGwMainnetV1()) {
contract.address = mainnetContractAddr;
contractAddress = mainnetContractAddr;
}

before(async function () {
if (contract.address) {
if (contractAddress) {
contract = await ethers.getContractAt("BlockInfo", contract.address);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contract.address is undefined at this time.

return;
}
Expand Down
Loading