This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: optimize Godwoken finality mechanism #132
Open
keroro520
wants to merge
9
commits into
godwokenrises:master
Choose a base branch
from
keroro520:new-finality-rule-based-on-timestamp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: optimize Godwoken finality mechanism #132
keroro520
wants to merge
9
commits into
godwokenrises:master
from
keroro520:new-finality-rule-based-on-timestamp
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keroro520
force-pushed
the
new-finality-rule-based-on-timestamp
branch
2 times, most recently
from
September 30, 2022 04:36
e61136e
to
1fdb028
Compare
Flouse
changed the title
feat: impl new finality rule
feat: optimize Godwoken finality mechanism
Oct 7, 2022
keroro520
changed the base branch from
master
to
breaking-change-next-upgrade
October 13, 2022 10:08
keroro520
force-pushed
the
new-finality-rule-based-on-timestamp
branch
from
October 13, 2022 10:10
1fdb028
to
0b45e20
Compare
keroro520
force-pushed
the
new-finality-rule-based-on-timestamp
branch
from
October 25, 2022 12:46
0b45e20
to
2836684
Compare
keroro520
force-pushed
the
new-finality-rule-based-on-timestamp
branch
from
November 2, 2022 11:06
74ebd43
to
47e3bda
Compare
keroro520
changed the base branch from
breaking-change-next-upgrade
to
master
November 3, 2022 07:33
jjyr
suggested changes
Nov 3, 2022
blckngm
reviewed
Nov 4, 2022
keroro520
force-pushed
the
new-finality-rule-based-on-timestamp
branch
from
November 7, 2022 13:47
0c759e8
to
5cc20fe
Compare
This was referenced Nov 29, 2022
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Overview
https://talk.nervos.org/t/optimize-godwoken-finality-and-on-chain-cost/6739
Implementation Note
Summary
The finality mechanism determines whether an entity has been finalized or not.
Entities that require finality checking must contain an attribution indicating their occuration time, which can be found in godwoken.mol:
Convention
In order to denote entities' occurrences, we define a compatible type,
Timepoint
:On-Chain Scripts