Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace set-output syntax and upgrade dep actions #85

Closed
wants to merge 1 commit into from

Conversation

ShookLyngs
Copy link

@ShookLyngs ShookLyngs commented Nov 28, 2022

Description

Command set-output/save-state is deprecated, and node@12 is also deprecated in GitHub action's runner.
To make sure everything works in the future, in this PR we should:

  • Replace all set-output syntax to be in sync with latest standard
  • Upgrade dependency actions to get rid of deprecated node@12 and save-state

Uncertain things

In the official blog, we were told that the set-output should be refactored like:

# from
- name: Set output
  run: echo "::set-output name={name}::{value}"
# to
- name: Set output
  run: echo "{name}={value}" >> $GITHUB_OUTPUT

The simplicity of the example make me feel uncertain about this specific case:

echo "::set-output name=$(3)-sha1::$$(git rev-parse HEAD)" >> ../../versions

How should I deal with this case, have I done it in the right way?
@Flouse Can you help me check on this, or should we just run the ci for a result?

Related issues

@ShookLyngs ShookLyngs requested a review from jjyr as a code owner November 28, 2022 16:07
@Flouse Flouse self-requested a review November 28, 2022 16:09
@ShookLyngs
Copy link
Author

Conflict with gw-monorepo branch, closing the PR.

@ShookLyngs ShookLyngs closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant