-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't throw exception when preview fetching timeouts #484
Shouldn't throw exception when preview fetching timeouts #484
Conversation
IMHO it's taking too long. Can we reduce the time net persistent times out? |
Also, there are at least one more error that can happen as well: http://bucket.dunnoapp.com/apps/54da0cd06432310009000000/problems/54fec4bf663133000f840000 |
That's funny, the Net::OpenTimeout error is addressed as the cause for the Net::HTTP::Persistent::Error. I'll try to catch it directly. How many seconds do you think it's appropriate to wait before the timeout? 5? |
Oops, actually the addressed cause is the Net::ReadTimeout. |
There is an ongoing issue about this. It seems it is rescuing this timeout error and it shouldn't, but there is probably somewhere else raising this error as well. We should rescue it. I think 5s is more than enough. |
There's no way to configure the read timeout for this gem, only the open timeout :/ |
Fork it, add the option, and issue a PR. |
Done |
096029e
to
f65e4a8
Compare
…imeout Shouldn't throw exception when preview fetching timeouts
@lunks
How to test it: