You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to the godot docs anyone can submit a pull request ... I think the main process for creating one is someone should submit an issue, and the pull request fixes that issue.
Tested versions
v4.2.2.stable.official [15073af]
System information
Ubuntu 22.04
Issue description
Mesh (such as a Sphere) is regenerated, wasting work, when the result will be exactly the same.
Steps to reproduce
Add this to a _process():
(in a real-world app, the value is calculated every frame based on user settings, but when the value is not changing, it still rebuilds the mesh)
Minimal reproduction project (MRP)
godot/scene/resources/3d/primitive_meshes.cpp
Line 1904 in fd4c29a
I'm wondering if a line like this would be appropriate:
Otherwise, the app has to do it in GDScript, which is much slower than C++, duplicated work across godot apps, etc.
I think this easy optimization should be added everywhere in Godot when changing a setting triggers heavy work.
If this is not implemented, then the docs should be updated to warn about the performance hit "even if setting to the same value".
The text was updated successfully, but these errors were encountered: