Stop progress_cb from generating spurious warnings
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`progress_cb` is used to give progress updates on pushes and pulls. There is no reason for it to pollute the logs by logging its updates as warnings. Changed these to plain print statements. Other fixes: * Removed unneeded `memcpy` in `progress_cb`: This buffer is already copied by `godot::String::utf8`, so no need to copy it a second time. * Fixed unmatched parenthesis in `push_transfer_progress_cb`: This just looked weird.
OpenSSL 1.1.1 [is EOL](https://www.openssl.org/blog/blog/2023/09/11/eol-111/index.html) since September 2023. Using an old version of SSL opens us up to vulnerabilities that have been fixed in newer versions, so we should keep it up to date. I have built and tested these libraries using the `build_openssl_universal_macos.sh` script on my own machine, and they work fine.
This reverts commit 2a552ed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress_cbis used to give progress updates on pushes and pulls. There isno reason for it to pollute the logs by logging its updates as warnings.
Changed these to plain print statements.
Other fixes:
memcpyinprogress_cb: This buffer is already copied bygodot::String::utf8, so no need to copy it a second time.push_transfer_progress_cb: This just lookedweird.