GitHub Workflow: Use new setup-godot-cpp github action from godot-cpp submodule. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
gh-action-setup-godot-cpp
branch
5 times, most recently
from
1e31d26 to
45f0369
Compare
Ivorforce
force-pushed
the
gh-action-setup-godot-cpp
branch
from
45f0369 to
0b5818e
Compare
|
Sorry for the repeated pushes... Somehow, I got stuck with git issues regarding the submodule. I simply don't understand those things... Anyway, the PR is updated to use the latest godot-cpp commit now. It should still run through. But we still shouldn't merge because that would upgrade the repo to godot 4.x. Should merge until the change is cherry-picked to 4.3 at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #68.
Do not merge this PR until godotengine/godot-cpp#1656 is merged.
This PR exists as a proof of concept until then, because it needs to modify the submodule version and remote to be testable.
Let's see if it runs!
Readme will be adjusted later. Not sure yet what to do with it, since it uses the 'run' action which I don't think is appropriate from this point on. Perhaps we'll just link the workflow and explain the parts separately?