Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: rm base_distro #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Apr 8, 2023

On the one hand, the base distro is hardcoded in the Dockerfiles. On the other hand, there are not multiple variants of the images using different base distros. Moreover, these images are expected to used along with scripts from godot-build-scripts. Therefore, the base distro is not very relevant in the name. In any case, it should not be a CLI argument which is independent from the hardcoded value.

@umarcor umarcor force-pushed the umarcor/base_distro branch 2 times, most recently from 554ae28 to 67f77b3 Compare April 9, 2023 00:31
@umarcor umarcor force-pushed the umarcor/base_distro branch from 67f77b3 to edeb37a Compare April 19, 2023 17:40
@Calinou Calinou added the enhancement New feature or request label Apr 19, 2023
@akien-mga
Copy link
Member

akien-mga commented May 24, 2023

I'm not fond of that change. The base distro defines a lot of the software we have available in the series of images, and while it's an approximation, it can usually be tied to a major update of these images.

For example now I'm considering doing an update of all images based on Fedora 38 with newer toolchains. I still want to keep my existing images for comparison, and if they would both be named 4.x, that's not much to go on.

We could introduce an arbitrary version number, but so far relying on the base distro was good enough for the 4.x branch (and for 3.x it's base distro + Mono version, as that one is updated more frequently).

That being said I'm open to suggestions for how to better handle versioning. I'm not an expert on good docker practices, and while 4.x-f36 is better than nothing, it's not fully satisfactory either.

@umarcor umarcor force-pushed the umarcor/base_distro branch from edeb37a to a17f03b Compare May 24, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants