Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement recommended thread access to prevent error spam on startup #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement recommended thread access to prevent error spam on startup #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions addons/debug_menu/debug_menu.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,21 +117,15 @@ func _ready() -> void:
# in case the user toggles the full debug menu just after starting the project.
information.text = "Loading hardware information...\n\n "
settings.text = "Loading project information..."

var viewport_rid_for_thread := get_viewport().get_viewport_rid()
thread.start(
func():
# Disable thread safety checks as they interfere with this add-on.
# This only affects this particular thread, not other thread instances in the project.
# See <https://github.com/godotengine/godot/pull/78000> for details.
# Use a Callable so that this can be ignored on Godot 4.0 without causing a script error
# (thread safety checks were added in Godot 4.1).
if Engine.get_version_info()["hex"] >= 0x040100:
Callable(Thread, "set_thread_safety_checks_enabled").call(false)

# Enable required time measurements to display CPU/GPU frame time information.
# These lines are time-consuming operations, so run them in a separate thread.
RenderingServer.viewport_set_measure_render_time(get_viewport().get_viewport_rid(), true)
update_information_label()
update_settings_label()
RenderingServer.viewport_set_measure_render_time(viewport_rid_for_thread, true)
call_deferred("update_information_label")
call_deferred("update_settings_label")
)

func _input(event: InputEvent) -> void:
Expand Down