Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metadata + Screenshots of Activities #103

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mayankkuthar
Copy link

No description provided.

@godiard
Copy link
Owner

godiard commented Dec 10, 2018

Why change the license in the metadata? @quozl this has been decided by the sugarlabs community?

@godiard
Copy link
Owner

godiard commented Dec 10, 2018

@vipulgupta2048, I see you requested the license change, why?

@quozl
Copy link
Collaborator

quozl commented Dec 10, 2018

Thanks for the pull request. Reviewed.

  • do not change the license metadata without explanation; we're waiting for your explanation, but my quick look at the source code shows helpactivity.py, viewtoolbar.py and setup.py are GPLv2+, and unless you have a good reason to change along with the authority as copyright owner to do so, please don't, (as a contractor for One Laptop per Child, I'm able to act for the copyright owner, so I'm interested in what you think the licence should change to),
  • please use the same size for all screenshots, so that they look the same when presented together; the existing screenshot is 1200x900, which was the native resolution of the OLPC XO laptop, but 1024x768 is a reasonable alternative,
  • each screenshot has a cost down the line; so please don't add more screenshots than are needed; for instance the third screenshot doesn't seem remarkable.

2443faa was where Seth Woodward changed license metadata from GPLv2 to GPLv3 as part of a merge. This may have been a mistake, I'm not sure.

@mayankkuthar
Copy link
Author

I have changed the license because vipulgupta2048, requested to change the license.
I have added the screenshot with 1024x768 size.
I have removed the third screenshot.

@vipulgupta2048
Copy link
Contributor

vipulgupta2048 commented Dec 10, 2018

Thanks @godiard @quozl
In the previous (now closed PR) I requested the change of GPLv3 to GPLv3+ as the addition of + made more sense in regards to the license. I didn't review the licenses in the files for that matter, as the PR (sugarlabs#5) would have to be closed regardless and the activity is trailing behind a lot of commits.

I agree with @quozl on the matter of license change and one shouldn't change it without the copyright owner's permission. @Gabbar8055 Do make the required changes.

@quozl
Copy link
Collaborator

quozl commented Dec 11, 2018

  • text is blurred, as if the screenshot was resized instead of being captured at the resolution.

@quozl
Copy link
Collaborator

quozl commented Dec 13, 2018

Thanks. Reviewed. Still has blur, as if using a different resolution for display. Also has blue bar on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants