-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support python 3.13 #539
Conversation
Cool! However, there's a lot of breakage in the CI testing... I think it's related to libgit2/pygit2#1317 -- neither our runners nor my workstation are prepared to deal with compiling-from-source in the absence of 3.13-compatible wheels. Hopefully this problem will solve itself in the near future. |
ah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stupid linters. :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll buy this. (At first I thought I'd accidentally committed some of my testing from yesterday because you'd made many of the exact same changes I considered!)
I see there's a types-pygit2
library that we could install to address many of the attr-defined
errors, but it feels like a cure that's worse than the disease -- it doesn't fix all of those errors, and it introduces a number type compatibility errors for known-working code. The resulting vibe I get is "not fully baked".
I think this PR reaches the goal of adding 3.13 support with the smallest amount of perturbation to the codebase. Thanks!
Happy to help! Meant to comment earlier but the Also |
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
What's new?
Just adding support for python 3.13. Poetry was locked to an older version of
pygit2
that can't be built on 3.13 so I had to add a newer version (which no longer supports python 3.8). Also ranpoetry update