Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build-in version for release tags #586

Merged
merged 2 commits into from
Nov 15, 2024
Merged

fix: build-in version for release tags #586

merged 2 commits into from
Nov 15, 2024

Conversation

bernhardreiter
Copy link
Member

  • Change Makefile to remove the leading v from the git tag
    in the case of release tags. Previously this was only done for
    pre-release git tags.

 * Change Makefile to remove the leading `v` from the git tag
   in the case of release tags. Previously this was only done for
   pre-release git tags.
Copy link
Collaborator

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@koplas koplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

@koplas koplas merged commit 1e3504c into main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix superfluous v in semver for release tags
3 participants