Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advisories: Time filter download by 'updated' field in ROLIE entries. #519

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Advisories: Time filter download by 'updated' field in ROLIE entries. #519

merged 2 commits into from
Dec 4, 2023

Conversation

s-l-teichmann
Copy link
Contributor

Solves #518

Now uses the updated field of ROLIE feed entries instead of the published field.

Drop time filtering in checker by folder year as this name stems from the publishing year
and not the latest update.

@s-l-teichmann s-l-teichmann linked an issue Dec 1, 2023 that may be closed by this pull request
Time filtered advisory downloads should use the update instead of the publish date. #518
Closed
@s-l-teichmann s-l-teichmann mentioned this pull request Dec 1, 2023
Closed
ThomasJunk
ThomasJunk approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

tschmidtb51
tschmidtb51 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-l-teichmann s-l-teichmann merged commit 03e4181 into main Dec 4, 2023
3 checks passed
@s-l-teichmann s-l-teichmann deleted the filter-download-by-update branch December 4, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschmidtb51 tschmidtb51 tschmidtb51 approved these changes

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@JanHoefelmeyer JanHoefelmeyer Awaiting requested review from JanHoefelmeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time filtered advisory downloads should use the update instead of the publish date.
3 participants
@s-l-teichmann @ThomasJunk @tschmidtb51