Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloader: Add tlp label to path if no custom directory is configured. Refactor accordingly #512

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Downloader: Add tlp label to path if no custom directory is configured. Refactor accordingly #512

merged 2 commits into from
Nov 21, 2023

Conversation

JanHoefelmeyer
Copy link
Contributor

Solves #511

ThomasJunk
ThomasJunk previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after looking up what lowermeant).

s-l-teichmann
s-l-teichmann approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ThomasJunk
ThomasJunk approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works.

@JanHoefelmeyer JanHoefelmeyer merged commit 2fe836b into main Nov 21, 2023
2 checks passed
@JanHoefelmeyer JanHoefelmeyer mentioned this pull request Nov 23, 2023
Closed
@JanHoefelmeyer JanHoefelmeyer deleted the Download_without_tlp branch May 8, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@s-l-teichmann s-l-teichmann s-l-teichmann approved these changes

@bernhardreiter bernhardreiter Awaiting requested review from bernhardreiter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanHoefelmeyer @s-l-teichmann @ThomasJunk