-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add function to find product identification helpers inspecting the tree #505
feat: Add function to find product identification helpers inspecting the tree #505
Conversation
…the tree Signed-off-by: juan131 <[email protected]>
Signed-off-by: juan131 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juan131 Thank you for your contribution.
The implementation is currently missing the evaluation of the items in relationships
(which can also define product_identification_helper
). See https://github.com/csaf-poc/csaf_distribution/blob/v3.0.0-rc.1/examples/purls_searcher/main.go as example.
Signed-off-by: juan131 <[email protected]>
Thanks for the advice @tschmidtb51 ! Implemented at 4338f45 |
I'm currently on a business trip - so it might take a while for me to review it. |
Friendly reminder to review this PR when you find the slot for it @tschmidtb51 |
Thank you for your contribution. We discussed it today. As it basically puts the implementation of the example in a more generic case, please also adopt the example to use the new library function. Also @s-l-teichmann had an idea about callbacks that might be helpful in the library. @s-l-teichmann please explain |
Example adapted at 2e9d4ad @tschmidtb51 |
@s-l-teichmann @tschmidtb51 friendly reminder |
@s-l-teichmann Please have a look |
I will have a look at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See juan131#1
Separate collecting and visiting of the product id helpers.
Thanks for the feedback @s-l-teichmann ! I applied your suggestions in the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is implemented by now.
Thanks everyone for you help! |
Description of the change
This PR adds a new exported method to
ProductTree
type in thecsaf
package:FindProductIdentificationHelpers
. This method iterates over the product tree and find the product identification helpers associated to a given product id.Benefits
Easier to obtain product identification helpers given a product id.
Possible drawbacks
None
Applicable issues
Additional information
N/A