Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time ranges: Accept days, months and years #483

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Time ranges: Accept days, months and years #483

merged 1 commit into from
Oct 19, 2023

Conversation

s-l-teichmann
Copy link
Contributor

Solves #480 .. at least integer values for years, days and month. The fractional cases like 1.5y are omitted as they are more complex.

JanHoefelmeyer
JanHoefelmeyer approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

ThomasJunk
ThomasJunk approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-l-teichmann s-l-teichmann merged commit 455010d into main Oct 19, 2023
2 checks passed
@s-l-teichmann s-l-teichmann deleted the parse-years-month-days branch October 19, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@bernhardreiter bernhardreiter Awaiting requested review from bernhardreiter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-l-teichmann @ThomasJunk @JanHoefelmeyer