Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding advisory model #473

Merged
merged 33 commits into from
Oct 25, 2023
Merged

Adding advisory model #473

merged 33 commits into from
Oct 25, 2023

Conversation

cintek
Copy link
Contributor

@cintek cintek commented Sep 29, 2023

This PR adds an advisory model including validation and methods to load and save an advisory.

cintek and others added 27 commits September 1, 2023 20:14
@cintek
feat: added model for a CSAF advisory
a1ea10b
@s-l-teichmann
Move defer.Close to right position.
96608a0
@s-l-teichmann
Add generator for CVSS enums
e821683
@cintek
Merge pull request #1 from s-l-teichmann/close-load-advisory
11c1a2c 
Move defer f.Close to right position.
@cintek
Merge pull request #2 from s-l-teichmann/generate-cvss-enums
12d2464 
Add generator for CVSS enums
@cintek
use generated types
f59a8cc
@cintek
added omitempty for cvss structs
4fc2fd9
@cintek
reusing TLPLabel and Category from models.go
3acabdf
@cintek
added missing types for CVSS2 + changed variable names for more consi…
7f36ecb 
…stency
@s-l-teichmann
Unexport patterns
22ef2a9
@cintek
Merge pull request #3 from s-l-teichmann/unexport-patterns
58bad8a 
Unexport patterns
@cintek
fixed versionPattern
f45d273
@cintek
added explanation for cvss3VectorStringPattern
b03df55
@cintek
only using enums from CVSS 3.0
4206c2e
@cintek
use up-to-date schema for CVSS 3.0
dc41aae
@cintek
use type FileHashValue
5a3661e
@cintek
added function to validate document
f868b13
@cintek
added function to validate ProductTree
ed42f19
@s-l-teichmann
Distribute the validation to the types to reduce the overall complexity.
4da9f67
@cintek
fix: product tree properties
bdd7f24
@cintek
Merge branch 'main' into cleanup-validation
094fe37
@cintek
Merge pull request #4 from s-l-teichmann/cleanup-validation
f145a63 
Simplify validation code
@cintek
completed validation of product tree
b5db976
@cintek
added validation for vulnerabilites
c8f1361
@cintek
dont use pointer for lists of elements
37cdda7
@s-l-teichmann
Fix typo in comment.
20b2bd2
@cintek
Merge pull request #5 from s-l-teichmann/fix-lint
b3332cf 
Fix typo in doc comment
@JanHoefelmeyer JanHoefelmeyer linked an issue Oct 12, 2023 that may be closed by this pull request
Make it easier to use csaf_distribution as go library to access CSAF file contents #367
Open
@JanHoefelmeyer JanHoefelmeyer removed a link to an issue Oct 12, 2023
Make it easier to use csaf_distribution as go library to access CSAF file contents #367
Open
JanHoefelmeyer
JanHoefelmeyer previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

@JanHoefelmeyer JanHoefelmeyer linked an issue Oct 12, 2023 that may be closed by this pull request
Basic Advisory Model to help handling Csaf Advisories #478
Closed
JanHoefelmeyer
JanHoefelmeyer approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Works

@ThomasJunk ThomasJunk self-requested a review October 20, 2023 07:07
ThomasJunk
ThomasJunk approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanHoefelmeyer JanHoefelmeyer merged commit 0905824 into gocsaf:main Oct 25, 2023
1 check passed
@JanHoefelmeyer JanHoefelmeyer mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@s-l-teichmann s-l-teichmann Awaiting requested review from s-l-teichmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Basic Advisory Model to help handling Csaf Advisories
5 participants
@cintek @ThomasJunk @JanHoefelmeyer @bernhardreiter @s-l-teichmann