Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests of internal packages #460

Merged
merged 19 commits into from
Sep 27, 2023
Merged

Unit tests of internal packages #460

merged 19 commits into from
Sep 27, 2023

Conversation

JanHoefelmeyer
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer commented Sep 20, 2023 •
edited by s-l-teichmann
Loading

Unit tests for /internal/

JanHoefelmeyer and others added 17 commits September 8, 2023 09:40
s-l-teichmann
s-l-teichmann previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

s-l-teichmann
s-l-teichmann previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

s-l-teichmann
s-l-teichmann approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works

@s-l-teichmann s-l-teichmann changed the title Unit tests Unit tests of internal packages Sep 25, 2023
ThomasJunk
ThomasJunk approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanHoefelmeyer JanHoefelmeyer merged commit a569b57 into main Sep 27, 2023
2 checks passed
@JanHoefelmeyer JanHoefelmeyer deleted the unit_tests branch September 27, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@s-l-teichmann s-l-teichmann s-l-teichmann approved these changes

@bernhardreiter bernhardreiter Awaiting requested review from bernhardreiter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanHoefelmeyer @s-l-teichmann @ThomasJunk