Checker: Fix checking of missing files

[JanHoefelmeyer]

Part of #438

Currently, any file discrepancies between the different file retrieval methods is reported in integrity.
This PR changes the checker so it reports any file missing from a list in their respective retrieval methods Requirement

[s-l-teichmann]

LGTM

[ThomasJunk]

Code looks good, BUT

I have a problem while testing.

Using the example data from the standard

"2020/example_company_-_2020-yh4711.json","2020-07-01T10:09:07Z"

results in

...
{
 "type": 2,
 "text": "Fetching https://127.0.0.1/.well-known/csaf/2020/example_company_-_2020-yh4711.json failed: Status code 404 (404 Not Found)"
},
...

Which is a result OK.

But there seems to be no complaint that this isn't found in any ROLIE or some similar message (which should be according to @JanHoefelmeyer ).

More:

Using

"2019/rhsa-2019_1862.json","2020-07-01T10:09:07Z"

results in

{
              "type": 2,
              "text": "Fetching https://127.0.0.1/.well-known/csaf/2019/rhsa-2019_1862.json failed: Status code 404 (404 Not Found)"
            },
...
            {
              "type": 2,
              "text": "https://localhost:8443/.well-known/csaf/amber/2019/rhsa-2019_1862.json in ROLIE, not in changes.csv"
            },
            {

which seems to be confusing. Going one step further:

Using

"amber/2019/rhsa-2019_1862.json","2020-07-01T10:09:07Z"

results in:

            {
              "type": 2,
              "text": "https://localhost:8443/.well-known/csaf/amber/2019/rhsa-2019_1862.json in ROLIE, not in changes.csv"
            },

which is confusing.

"amber/2019/rhsa-2019_1862.json","2020-07-01T10:09:07Z" shouldn't be standard conform.
I expected it either to be found and the errormessage about it missing wouldn't appear or it would be listed as "not found" like with the example data.

Am I testing wrong here or is there a bug hidden?

Aside: The date part seems to be neglectable as long a date is present in an entry.

[ThomasJunk]

Okay using URLs seems to work. I misread the standard saying:

The file changes.csv MUST contain the filename

which should read

The file changes.csv MUST contain URL pointing to the file.

[ThomasJunk]

LGTM and using URLs it works.

[s-l-teichmann]

Jan mentioned yesterday there is something wrong with this he still wants to fix. I currently do not know any more details. Postponing merge ATM.

[bernhardreiter]

@JanHoefelmeyer please fix what you have planned to fix.

[bernhardreiter]

(I have added a review so that merging is blocked until @JanHoefelmeyer can do his fixes next week.)

[s-l-teichmann]

(I have added a review so that merging is blocked until @JanHoefelmeyer can do his fixes next week.)

The "right" way to prevent this is to set it back to draft.

[JanHoefelmeyer]

Opened #451 and #452 since the issues of the PR discussed here do not originate from these changes, nor are they part of #438.

[s-l-teichmann]

Still LGTM

[ThomasJunk]

LGTM & Works

No actual changes requested.